Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted Top Alignment in Mobile View #353 #357

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Adjusted Top Alignment in Mobile View #353 #357

merged 1 commit into from
Feb 18, 2025

Conversation

Shrutim1505
Copy link
Contributor

Fixed #352

Hi @Arhell @Monokaix , I guess I did not cleary communicated my fix.

whenever we open https://volcano.sh/en/docs/ in mobile view their is alignment issue there in ,
specified in #352

Example:-

Screenshot from 2025-02-15 11-38-27

to :-
Screenshot from 2025-02-15 11-40-46

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2025
@Shrutim1505
Copy link
Contributor Author

Hi @Monokaix I accidently closed a PR docs_layout/fix while squasing my commits, which I couldnt repoen,
here i updated it , please check

@Shrutim1505 Shrutim1505 force-pushed the new branch 2 times, most recently from e711cc8 to a02edf9 Compare February 15, 2025 07:04
@Shrutim1505
Copy link
Contributor Author

/assign @k82cn
@Arhell @Monokaix done

@Shrutim1505 Shrutim1505 force-pushed the new branch 2 times, most recently from cb19a43 to 5713a64 Compare February 15, 2025 07:24
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2025
@Shrutim1505 Shrutim1505 force-pushed the new branch 2 times, most recently from 380708d to 26db755 Compare February 15, 2025 08:16
@Arhell
Copy link
Member

Arhell commented Feb 15, 2025

and start from 1200px

@Arhell
Copy link
Member

Arhell commented Feb 15, 2025 •
edited
Loading

and start from 1200px

in other words leave only

.container-fluid.docs {
padding-top: 0 !important;
}

that's enough

@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2025
@Shrutim1505
Copy link
Contributor Author

and start from 1200px

in other words leave only

.container-fluid.docs { padding-top: 0 !important; }

that's enough

thanks @Arhell , No extra padding was indeed required. Updated as per u said

@Shrutim1505
fixed docs alignment in mobile view
d98b0bf 
Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

fixed docs alignment in mobile view

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

fixed docs alignment in mobile view

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

fixed responsiveness

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

 layout/fix

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>

code updation

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>
@Arhell
Copy link
Member

Arhell commented Feb 15, 2025

@Shrutim1505 Excellent, thank you.
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2025
@Arhell Arhell mentioned this pull request Feb 17, 2025
Closed
kevin-wangzefeng
kevin-wangzefeng reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@volcano-sh-bot volcano-sh-bot merged commit a1487b4 into volcano-sh:master Feb 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@Arhell Arhell Awaiting requested review from Arhell

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@k82cn k82cn

@Arhell Arhell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Misaligned Top Spacing in Mobile View
5 participants
@Shrutim1505 @Arhell @volcano-sh-bot @kevin-wangzefeng @k82cn